feat(android): added configurable icon color for local notifications #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Mar 16, 2020
...d/capacitor/src/main/java/com/getcapacitor/plugin/notification/LocalNotificationManager.java
Outdated
Show resolved
Hide resolved
...d/capacitor/src/main/java/com/getcapacitor/plugin/notification/LocalNotificationManager.java
Outdated
Show resolved
Hide resolved
|
BTW, can you document the plugin preferences you can add in the |
|
sure thing, I will add small Icon too as I don't think that was added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
I was finding that I needed to customize quite a few things with android local notifications so I decided to put my first PR in to see how it goes.
This PR adds the ability to set an icon color in android. You can do it with the plugin definition or globally in the config.
If this is something the community is interested in... i have already done something similar to make the notification expandable and can put that PR in at some point in the future as well.