fix(core): use own type for backButton event result #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
force-pushed
the
backbutton-type-fix
branch
from
156ad9d
to
999ca16
Compare
|
Yeah, it wouldn't break the app's compilation to add parameters later, so I'm not sure why we do that. We can merge this though because I imagine we'll be cleaning up the types as we move these definitions into their respective plugin packages. |
imhoffd
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sending to main since the type change is probably a breaking change, apps using the
AppUrlOpenimport would need to change toBackButtonResultcloses #3346
There are a few listeners that just return
{}, should we just return nothing for such cases?