feat(iOS): Refactoring configuration #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikeith
changed the title
imhoffd
reviewed
Nov 9, 2020
2 tasks
…InstanceConfiguration. Removed reference to CAPConfig from CAPLog and replaced with a static flag.
ikeith
force-pushed
the
configuration
branch
from
ce2cb01
to
e30e927
Compare
imhoffd
reviewed
Nov 20, 2020
| for (itemIndex, item) in items.enumerated() { | ||
| Swift.print(item, terminator: itemIndex == items.count - 1 ? terminator : separator) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public static func hideLogs() -> Bool { |
There was a problem hiding this comment.
Not sure why this was public to begin with, but just noting that it is something being removed from the public API.
There was a problem hiding this comment.
Yeah, its replacement property is public as well but we should probably note that.
Good catch. It's an unused forward declaration so, no, it's not a problem but it should be removed anyway. |
1 task
jcesarmobile
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch revisits configuration with multiple goals:
Move the configuration store away from a key/value container to typed properties. This reduces the risk of "stringly-typed" parsing scattered around the project and improves type safety.
Centralize all configuration defaults and file keys so they are not spread over the codebase. This also allows for easier testing and updating of the configuration file.
Provide a programmatic structure so applications can configure the capacitor bridge without relying on injecting JSON.
Add unit tests.
The configuration file(s) is parsed into an intermediate structure which can be modified (supported in a future refactoring of CAPBridgeViewController), and then transformed into an immutable store on the bridge.
CAPLog has been updated to use a simple boolean to control logging instead of loading a second instance of CAPConfig (and making assumptions about its location). The initialization has been reworked to set that flag based on the configuration before any logging might occur.