feat(iOS): Add local and remote notification router #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikeith
suggested changes
Nov 25, 2020
| @@ -17,6 +17,7 @@ NS_SWIFT_NAME(InstanceConfiguration) | |||
| @property (nonatomic, readonly) BOOL enableLogging; | |||
| @property (nonatomic, readonly) BOOL enableScrolling; | |||
| @property (nonatomic, readonly) BOOL allowLinkPreviews; | |||
| @property (nonatomic, readonly) BOOL assignUserNotificationCenterDelegate; | |||
There was a problem hiding this comment.
Does this need a field in the config file? Otherwise turning it off will require that the app developer subclass the view controller to programmatically set it.
There was a problem hiding this comment.
I don't think so. Disabling it is likely only a use case for embedded. If I'm mistaken, we can always add a field later.
Co-authored-by: Ian Keith <iankeith@gmail.com>
imhoffd
changed the title
ikeith
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
UNUserNotificationCenter.delegatevia configuration (waiting on config stuff to get merged)waiting on #3759