-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): Add local and remote notification router #3796
Conversation
@@ -17,6 +17,7 @@ NS_SWIFT_NAME(InstanceConfiguration) | |||
@property (nonatomic, readonly) BOOL enableLogging; | |||
@property (nonatomic, readonly) BOOL enableScrolling; | |||
@property (nonatomic, readonly) BOOL allowLinkPreviews; | |||
@property (nonatomic, readonly) BOOL assignUserNotificationCenterDelegate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a field in the config file? Otherwise turning it off will require that the app developer subclass the view controller to programmatically set it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Disabling it is likely only a use case for embedded. If I'm mistaken, we can always add a field later.
Co-authored-by: Ian Keith <iankeith@gmail.com>
TODO:
UNUserNotificationCenter.delegate
via configuration (waiting on config stuff to get merged)waiting on #3759