fix: fix isPluginAvailable() for web and native #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, can you please release it in beta as soon as possibile, thx. |
|
@mburger81 Unfortunately this PR does not yet address all the issues with |
imhoffd
changed the title
imhoffd
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the idea of "plugin headers" that are written to JS alongside the plugin skeleton implementations.
This is required because the core refactor changed how the
Capacitor.Pluginsobject is populated and brokeisPluginAvailable(). The new headers are necessary to know if a plugin has an implementation on native.isPluginAvailable()has been updated to check JS and native implementations.I want to do a refactor later to remove the plugin skeleton implementations because they're unnecessary with our proxy and with bundling the core together.