fix(cli): add vite config to framework detection #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds vite framework detection to hopefully help with some detection issues around svelte. Older svelte projects used the public directory, but newer ones use vite as the primary bundler which has `dist` as the output directory. This should also add support for other vite-based frameworks such as solidjs.
dallastjames
requested review from
giralte-ionic,
IT-MikeS,
ItsChaceD,
jcesarmobile and
theproducer
giralte-ionic
approved these changes
Oct 28, 2022
IT-MikeS
approved these changes
Oct 28, 2022
theproducer
approved these changes
Oct 28, 2022
jcesarmobile
approved these changes
Oct 28, 2022
jcesarmobile
changed the title
|
Vite detection hasn't been added to tests: https://github.com/ionic-team/capacitor/blob/main/cli/test/framework-detection.spec.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vite framework detection to hopefully help with some detection issues around svelte. Older svelte projects used the public directory, but newer ones use vite as the primary bundler which has
distas the output directory. This should also add support for other vite-based frameworks such as solidjs.