[Bug]: Sending TypedArray as fetch body gets JSON.stringified

[marcelklehr]

Capacitor Version

Latest Dependencies:

@capacitor/cli: 6.0.0
@capacitor/core: 6.0.0
@capacitor/android: 6.0.0
@capacitor/ios: 6.0.0

Installed Dependencies:

@capacitor/cli: 5.7.5
@capacitor/core: 5.7.5
@capacitor/android: 5.7.5
@capacitor/ios: 5.5.1

[success] Android looking great! 👌
[error] Xcode is not installed

Other API Details

npm --version
10.7.0

node --version
v20.9.0

Platforms Affected

• iOS
• Android
• Web

Current Behavior

sending a POST via fetch with a UInt8Array as body results in the TypedArray getting stringified as JSON.

callback: 40428488, pluginId: CapacitorHttp, methodName: request, methodData: {"url":"https://github.com/marcelklehr/test.git/git-upload-pack","method":"POST","data":{"0":48,"1":48,"2":56,"3":....

Expected Behavior

The binary data sould be sent unchanged.

Project Reproduction

https://github.com/floccusaddon/floccus

Additional Information

No response

[jcesarmobile]

please, provide a sample app that reproduces the issue, not a full app with no indications about how to run or reproduce

[marcelklehr]

Here you go: https://github.com/marcelklehr/capactitor-repro-fetch-uint8array

[ionitron-bot]

This issue has been labeled as type: bug. This label is added to issues that that have been reproduced and are being tracked in our internal issue tracker.

[faan11]

This is how it works from my understanding:

• for android or web: the convertBody function detects the type

  capacitor/core/native-bridge.ts

  Line 767 in 0ad0c3f

  convertBody(body).then(({ data, type, headers }) => {

  (also the ios platform calls this one)
• the type detection is based on the content type. The integer value is treat as a text since no content-type was specified here:

  capacitor/core/native-bridge.ts

  Line 91 in 0ad0c3f

  type = 'text';

• the function request is called
• this is the android implementation of request:

  capacitor/android/capacitor/src/main/java/com/getcapacitor/plugin/CapacitorHttp.java

  Line 91 in 0ad0c3f

  public void request(final PluginCall call) {

• the capacitorhttp class calls HttpRequestHandler request method

  capacitor/android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java

  Line 385 in 0ad0c3f

  public static JSObject request(PluginCall call, String httpMethod, Bridge bridge)

  which gets the datatype and data
• calls setRequestBody

  capacitor/android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java

  Line 423 in 0ad0c3f

  connection.setRequestBody(call, data, dataType);

• The last case should convert the raw data into string because it does not know how to handle it:

  capacitor/android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java

  Line 229 in 0ad0c3f

  this.writeRequestBody(body.toString());

• Even if the type is recognized as json: the text is converted to string which treats integer as a string.

  capacitor/android/capacitor/src/main/java/com/getcapacitor/plugin/util/CapacitorHttpUrlConnection.java

  Line 201 in 0ad0c3f

  dataString = body.toString();

From this analysis, all platforms should be affected by this bug since the convertBody function is shared by ios, android and web.
In my opinion, the solution depends on the body type:

• if the body is a integer, the convertbody function should detect that the value is an integer. The platform implementation should handle integer values as well.
• if the body is a json, we should use json.Stringify instead of the common toString method in the platform implementation side.

In both cases, a new function is needed to write mixed data (string+integer) to the outputstream (like writeRequestBody does for string).

Please correct me if I said something wrong. I hope this might help to solve this issue.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.