Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): allow Share plugin to provide text or url only #2436

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

veloce
Copy link
Contributor

@veloce veloce commented Feb 12, 2020

Currently, without this fix, either text only or url only sharing does not work.

I added two more buttons on example app to show that now it is working.

@veloce veloce changed the title bug: fix share plugin on android fix(android) share plugin bug when providing text or url only Feb 12, 2020
@veloce veloce changed the title fix(android) share plugin bug when providing text or url only fix(android): share plugin bug when providing text or url only Feb 12, 2020
@krimsonkla
Copy link

Any word on when this will launch? This was working and is blocking our migration launch from Cordova to capacitor. Thanks for the awesome work on this project!

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile changed the title fix(android): share plugin bug when providing text or url only fix(android): allow Share plugin to provide text or url only Mar 17, 2020
@jcesarmobile jcesarmobile merged commit b6328f0 into ionic-team:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants