Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Support CORS when using Live Reload #2882

Closed
wants to merge 1 commit into from
Closed

fix(ios): Support CORS when using Live Reload #2882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
55 changes: 37 additions & 18 deletions ios/Capacitor/Capacitor/CAPAssetHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,29 +24,48 @@ class CAPAssetHandler: NSObject, WKURLSchemeHandler {
let localUrl = URL.init(string: url.absoluteString)!
let fileUrl = URL.init(fileURLWithPath: startPath)

// CORS support
let origin = urlSchemeTask.request.value(forHTTPHeaderField: "origin")
var headers = origin != nil ? [
"Access-Control-Allow-Origin": origin!,
"Access-Control-Allow-Methods": "GET, OPTIONS",
] : [String: String]()

do {
var data = Data()
if !stringToLoad.contains("cordova.js") {
switch urlSchemeTask.request.httpMethod {
case "GET":
var data = Data()
if !stringToLoad.contains("cordova.js") {
if isMediaExtension(pathExtension: url.pathExtension) {
data = try Data(contentsOf: fileUrl, options: Data.ReadingOptions.mappedIfSafe)
} else {
data = try Data(contentsOf: fileUrl)
}
}
let mimeType = mimeTypeForExtension(pathExtension: url.pathExtension)
let expectedContentLength = data.count

headers["Content-Type"] = mimeType
headers["Cache-Control"] = "no-cache"

let urlResponse = URLResponse(url: localUrl, mimeType: mimeType, expectedContentLength: expectedContentLength, textEncodingName: nil)
let httpResponse = HTTPURLResponse(url: localUrl, statusCode: 200, httpVersion: nil, headerFields: headers)
if isMediaExtension(pathExtension: url.pathExtension) {
data = try Data(contentsOf: fileUrl, options: Data.ReadingOptions.mappedIfSafe)
urlSchemeTask.didReceive(urlResponse)
} else {
data = try Data(contentsOf: fileUrl)
urlSchemeTask.didReceive(httpResponse!)
}
urlSchemeTask.didReceive(data)
case "OPTIONS":
// CORS preflight
let response = HTTPURLResponse(url: localUrl, statusCode: 200, httpVersion: nil, headerFields: headers)
urlSchemeTask.didReceive(response!)

default:
// method not allowed
let response = HTTPURLResponse(url: localUrl, statusCode: 405, httpVersion: nil, headerFields: headers)
urlSchemeTask.didReceive(response!)
}
let mimeType = mimeTypeForExtension(pathExtension: url.pathExtension)
let expectedContentLength = data.count
let headers = [
"Content-Type": mimeType,
"Cache-Control": "no-cache"
]
let urlResponse = URLResponse(url: localUrl, mimeType: mimeType, expectedContentLength: expectedContentLength, textEncodingName: nil)
let httpResponse = HTTPURLResponse(url: localUrl, statusCode: 200, httpVersion: nil, headerFields: headers)
if isMediaExtension(pathExtension: url.pathExtension) {
urlSchemeTask.didReceive(urlResponse)
} else {
urlSchemeTask.didReceive(httpResponse!)
}
urlSchemeTask.didReceive(data)
} catch let error as NSError {
urlSchemeTask.didFailWithError(error)
return
Expand Down