Extend device plugin #3244
Merged
Extend device plugin #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work! Thank you! 🎉 |
|
@dwieeb my pleasure! Do you already know when you are going to release the next version containing this feature? I also would like to update the docs. Should I do this now or wait for the release? |
|
Yes, the 2.3.0 release is planned for tomorrow. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
appName(the app's display name) andappId(the app's bundle id) toDevice.getInfo().I thought this can come in handy when gathering debug information. After moving one of my apps over from Cordova,
cordova-plugin-app-versionis the only remaining plugin I can not remove just yet as I need to display the app's name and bundle id.