Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): use more explicit result for Browser plugin events #3349

Merged
merged 3 commits into from Jul 28, 2020
Merged

feat(core): use more explicit result for Browser plugin events #3349

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17d5aff
feat(core): use more explicit result for Browser plugin events
jcesarmobile Jul 28, 2020
01aca93
Merge branch 'main' into browser-info-types
jcesarmobile Jul 28, 2020
8092614
Merge branch 'main' into browser-info-types
imhoffd Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/core-plugin-definitions.ts
View file
Open in desktop
Expand Up @@ -267,18 +267,20 @@ export interface BrowserPlugin extends Plugin {

addListener(
eventName: 'browserFinished',
listenerFunc: (info: any) => void,
listenerFunc: (info: BrowserInfo) => void,
): PluginListenerHandle;
addListener(
eventName: 'browserPageLoaded',
listenerFunc: (info: any) => void,
listenerFunc: (info: BrowserInfo) => void,
): PluginListenerHandle;
/**
* Remove all native listeners for this plugin
*/
removeAllListeners(): void;
}

export interface BrowserInfo {}

export interface BrowserOpenOptions {
/**
* The URL to open the browser to
Expand Down