Support CORS when using Live Reload #3433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If server.url is modified, i.e. using live reload
|
@diachedelic are you still running cap 2? |
|
@riderx Yes, why do you ask? |
|
Because it's 2 years old maybe it was outdated, and not necessary :) |
|
I think this fix is still relevant to Capacitor 3. The relevant file was renamed to WebViewAssetHandler.swift, but was not substantially changed. This patch still applies. |
|
@diachedelic i understand, but there are no really point to stay in capacitor 2. for me :/ |
|
closing since capacitor 2 is not supported and a similar change is already present in newer versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A repeat of #2882, with some improvements.
Even if this will be superseded by Capacitor v3, I would still like to see this merged for v2. I am using
patch-packagefor now :(