Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add capacitor run command #3599

Merged
merged 39 commits into from Oct 16, 2020
Merged

feat(cli): add capacitor run command #3599

merged 39 commits into from Oct 16, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Sep 22, 2020 •
edited

TODO:

  • iOS
  • native-run installation instructions when not found
  • more error handling

closes #3142
depends on #3565

imhoffd and others added 24 commits September 9, 2020 15:50
@imhoffd
strip params from check functions
8c3d3e0
@imhoffd
resolveNode doesn't need config
2762d7f
@imhoffd
remove public config methods and unused properties
ca1510d
@imhoffd
config refactor
172f594
@imhoffd
readonly
5381669
@imhoffd
bug fixes
8665579
@imhoffd
fix tests
b2c4f92
@imhoffd
be more clear about resolving package.json
5b0f13a
@imhoffd
Merge branch 'main' into config-refactor
ff836cb 
Conflicts:
	cli/src/android/add.ts
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/android/open.ts
	cli/src/android/update.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/cordova.ts
	cli/src/index.ts
	cli/src/ios/add.ts
	cli/src/ios/common.ts
	cli/src/ios/doctor.ts
	cli/src/ios/open.ts
	cli/src/ios/update.ts
	cli/src/plugin.ts
	cli/src/tasks/add.ts
	cli/src/tasks/copy.ts
	cli/src/tasks/create.ts
	cli/src/tasks/doctor.ts
	cli/src/tasks/init.ts
	cli/src/tasks/list.ts
	cli/src/tasks/new-plugin.ts
	cli/src/tasks/open.ts
	cli/src/tasks/serve.ts
	cli/src/tasks/sync.ts
	cli/src/tasks/update.ts
	cli/src/web/copy.ts
	cli/test/util.ts
@imhoffd
Merge branch 'main' into config-refactor
a9ee8be
@imhoffd
refactor platformDir
c04c10f
@imhoffd
implement ios.path and android.path
b6f3407
@imhoffd
Merge branch 'main' into config-refactor
16ce02c
@imhoffd @jcesarmobile
Update cli/src/config.ts
151a41f 
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@imhoffd
show plugin config last when adding it
be4e89d
@imhoffd
Merge branch 'main' into config-refactor
8cf2ac8
@imhoffd
write plugin last (attempt 2 😂)
74b85be
@imhoffd
FS refactor
146907d
@imhoffd
wip
f0e4d09
@imhoffd
Merge remote-tracking branch 'origin/main' into feat-2294
2b2242c 
Conflicts:
	cli/src/android/update.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/definitions.ts
	cli/src/ios/common.ts
	cli/src/tasks/add.ts
@imhoffd
Merge branch 'feat-2294' into run-command
9cf740d 
Conflicts:
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/ios/common.ts
@imhoffd
refactor runCommand to use subprocess lib
9801331
@imhoffd
poc for android
953e91b
@imhoffd
test fix
c7865fc
@imhoffd imhoffd added this to the 3.0.0 milestone Sep 22, 2020
@imhoffd imhoffd added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Sep 22, 2020
@imhoffd
Merge remote-tracking branch 'origin/main' into run-command
6d1f242 
Conflicts:
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/common.ts
	cli/src/ios/common.ts
	cli/src/ios/update.ts
@imhoffd
target and list options
9eeb26a
@imhoffd
debug messages
b358102
@imhoffd
ignore DerivedData where builds are placed
b189dc2
@imhoffd imhoffd marked this pull request as ready for review September 29, 2020 22:39
jcesarmobile
jcesarmobile reviewed Oct 15, 2020
View reviewed changes
cli/src/common.ts Outdated Show resolved Hide resolved
jcesarmobile
jcesarmobile reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment.

For future PRs would be good if they stick to adding just the functionality and not doing a major refactor as it makes extremely hard to review and focus on the important changes.

@imhoffd imhoffd merged commit 8576b0f into main Oct 16, 2020
Capacitor Engineering ⚡️ automation moved this from In progress 🤺 to Done 🎉 Oct 16, 2020
@imhoffd imhoffd deleted the run-command branch October 16, 2020 15:42
imhoffd added a commit that referenced this pull request Oct 16, 2020
@imhoffd
feat(cli): add capacitor run command (#3599)
68e872d
@imhoffd imhoffd mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

Add capacitor run command
2 participants
@imhoffd @jcesarmobile