Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): do not require webDir when server.url is set #4200

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Feb 12, 2021

The Capacitor CLI developer experience can be improved when using livereload by not requiring the web asset directory to exist if server.url is being used.

BEFORE:

image

AFTER:

image

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Feb 12, 2021
@imhoffd imhoffd linked an issue Feb 12, 2021 that may be closed by this pull request
@imhoffd imhoffd merged commit 91ddfbd into main Feb 16, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Feb 16, 2021
@imhoffd imhoffd deleted the optional-copy branch February 16, 2021 18:41
@imhoffd imhoffd added this to the 3.0.0-rc milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Do not copy web assets if server.url is set
2 participants