Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Use proper native events for cordova events #4720

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix(ios): Use proper native events for cordova events #4720

merged 1 commit into from
Jun 14, 2021

Conversation

jcesarmobile
Copy link
Member

cordova uses willEnterForegroundNotification instead of didBecomeActiveNotification for resume event and didEnterBackgroundNotification instead of willResignActiveNotification for pause event, so this should work the same way

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Jun 14, 2021
@jcesarmobile jcesarmobile requested a review from ikeith June 14, 2021 11:52
@jcesarmobile jcesarmobile merged commit 99c21dc into main Jun 14, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jun 14, 2021
@jcesarmobile jcesarmobile deleted the fix-cord-evt branch June 14, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcesarmobile @ikeith