fix(android): restrict android run command to configured flavour #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandor-biro
changed the title
adrianpunkt
reviewed
Nov 19, 2021
| @@ -19,7 +19,8 @@ export async function runAndroid( | |||
| selectedTarget, | |||
| ); | |||
|
|
|||
| const gradleArgs = ['assembleDebug']; | |||
| const arg = `assemble${config.android?.flavor || ''}Debug`; | |||
There was a problem hiding this comment.
@sandor-biro You still need the word Debug, the correct argument is actually assembleFlavorDebug where Flavor is the value from the config
There was a problem hiding this comment.
Debug word is at the end of the template string, so if there is a flavor it will be assembleFlavorNameDebug and if not assembleDebug
|
Can you run |
carlpoole
changed the title
carlpoole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves request: #5252
Live reload should now work with any
productFlavor.