Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Empty fallback if no non-dev dependencies #6707

Merged
merged 2 commits into from Jul 12, 2023
Merged

fix(cli): Empty fallback if no non-dev dependencies #6707

merged 2 commits into from Jul 12, 2023

Conversation

petermakeswebsites
Copy link
Contributor

Migration was throwing an error because I only had dev dependencies.

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at installLatestLibs (/Users/pete/Development/GitHub/acimce-kit/node_modules/@capacitor/cli/dist/tasks/migrate.js:257:33)

jcesarmobile
jcesarmobile approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'll merge to prevent problems, but note that all your capacitor plugins and capacitor packages except for the CLI should be dependencies, not dev dependencies.

@jcesarmobile jcesarmobile merged commit 25ca83a into ionic-team:main Jul 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petermakeswebsites @jcesarmobile