Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing \r\n after Content-Disposition in iOS #6722

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

5uper
Copy link
Contributor

@5uper 5uper commented Jul 12, 2023

This is related on feat(http): support for FormData requests #6708

When comparing FormData with the type string and base64File we see that in the case string a second \r\n is missing after content disposition in iOS. This leads to the fact that we receive a 400 Bad Request from the server with a request from iOS.

image

In HTTP version 1.x, header fields are transmitted after the request line (in case of a request HTTP message) or the response line (in case of a response HTTP message), which is the first line of a message. Header fields are colon-separated key-value pairs in clear-text string format, terminated by a carriage return (CR) and line feed (LF) character sequence. The end of the header section is indicated by an empty field line, resulting in the transmission of two consecutive CR-LF pairs.
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields

@markemer markemer merged commit 427da42 into ionic-team:main Jul 12, 2023
6 checks passed
@5uper 5uper deleted the fix-http-form-data-ios branch July 13, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants