Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Specify keystore alias and alias password build options for apksigner #7073

Merged
merged 7 commits into from
Jan 3, 2024
Merged

fix(cli): Specify keystore alias and alias password build options for apksigner #7073

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c951d6e
Specify keystore alias and alias password to fix #7054
bentleyo Nov 16, 2023
f9276d7
Merge branch 'main' into bugfix/apksigner-alias
markemer Nov 28, 2023
89c9a72
Merge branch 'main' into bugfix/apksigner-alias
markemer Nov 30, 2023
9469ddf
Merge branch 'main' into bugfix/apksigner-alias
giralte-ionic Dec 12, 2023
fd06a03
Check keystore options are passed in before adding to signing args
bentleyo Dec 21, 2023
80dcdf9
Merge branch 'main' into bugfix/apksigner-alias
theproducer Jan 2, 2024
c597c4e
fmt
theproducer Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cli/src/android/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@ async function signWithApkSigner(
`${join(releasePath, signedReleaseName)}`,
];

if (buildOptions.keystorealias) {
signingArgs.push('--ks-key-alias', buildOptions.keystorealias);
}

if (buildOptions.keystorealiaspass) {
signingArgs.push('--key-pass', buildOptions.keystorealiaspass);
}

await runTask('Signing Release', async () => {
await runCommand('apksigner', signingArgs, {
cwd: config.android.platformDirAbs,
Expand Down