fix(android): don't proxy requests if no jsInjector #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
carlpoole and
giralte-ionic
carlpoole
approved these changes
Jan 19, 2024
markemer
approved these changes
Jan 22, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using live reload or loading from an external server all requests are still being proxied, but they shouldn't as the new injector doesn't really need to proxy requests anymore, it's just there as fallback in case the jsInjector doesn't work for some reason.
I've moved the
if (jsInjector != null)check to be the first thing so it doesn't proxy if not needed.closes #4240
closes #4437
closes #5301
closes #5428
closes #5872
closes #6449