Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): Add xcprivacy for Capacitor and Cordova #7322

Merged
merged 5 commits into from Mar 11, 2024
Merged

chore(ios): Add xcprivacy for Capacitor and Cordova #7322

merged 5 commits into from Mar 11, 2024

Conversation

Steven0351
Copy link
Member

supersedes #7315 with new branch naming rules

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Mar 7, 2024
@Steven0351 Steven0351 mentioned this pull request Mar 7, 2024
Closed
jcesarmobile
jcesarmobile reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit you made on the other PR included NSPrivacyAccessedAPICategoryUserDefaults but now that's gone, isn't it necessary in the 5.x branch because of the UserDefaults usage?

@Steven0351
Copy link
Member Author

The first commit you made on the other PR included NSPrivacyAccessedAPICategoryUserDefaults but now that's gone, isn't it necessary in the 5.x branch because of the UserDefaults usage?

Yes indeed. I must have gone overboard when adding all the other empty keys and accidentally deleted it 😬. Good catch, thanks.

@Steven0351 Steven0351 merged commit 6c7a7b0 into 5.x Mar 11, 2024
6 checks passed
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Mar 11, 2024
@Steven0351 Steven0351 deleted the RDMR-57 branch March 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@markemer markemer Awaiting requested review from markemer

@theproducer theproducer Awaiting requested review from theproducer

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Steven0351 @jcesarmobile @giralte-ionic