Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Height Value on some Android devices #157

Open
kensodemann opened this issue Jan 19, 2021 · 2 comments · May be fixed by #164
Open

Incorrect Height Value on some Android devices #157

kensodemann opened this issue Jan 19, 2021 · 2 comments · May be fixed by #164

Comments

@kensodemann
Copy link
Member

On certain devices (Dallas helped me test it on his Galaxy S10 as I could not replicate it on the Pixel devices I have), the @ionic-enterprise/keyboard plugin will report the height of the keyboard as one value, and the Capacitor plugin will report a different value.

For Dallas it was:
Cordova: 333
Capacitor: 375

The customer had similar results. In both cases, the larger Capacitor number appears to be the correct value.

To replicate this, I created the following app: https://github.com/kensodemann/test-keyboard-height

There are two useful branches here:

cordova: Cordova app, uses @ionic-enterprise/keyboard

capacitor: Capacitor app, uses Capacitor Keyboard API plugin
@mattylight22
Copy link

@kensodemann have you figured anything out with this. I’m having an identical problem.

@kensodemann
Copy link
Member Author

@mattnick89 - there is a premier version of this plugin and it has been fixed there. Apparently, the same PR has not made its way in to the community version of the plugin, though it is marked as a future TODO (see the projects to the right). That team, however, is currently focused heavily on getting Capacitor v3 out the door.

The PR for the premier plugin was based on the following PR for Capacitor: ionic-team/capacitor#2924

@tzappia tzappia linked a pull request Jun 2, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Android: incorrect keyboard height on devices with cutouts tzappia/cordova-plugin-ionic-keyboard
2 participants
@kensodemann @mattylight22