Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error page if server is not running #207

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

jcesarmobile
Copy link
Member

No description provided.

Copy link
Contributor

@mlynch mlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there also be a way to listen for a socket bind error so we know for sure?

@jcesarmobile
Copy link
Member Author

No, GCDWebServerDelegate doesn't have a method for when binding fails, it just logs an error message.

But I tested this code and isRunning is false when the binding failed.

@mlynch mlynch merged commit ecc83dc into ionic-team:master Nov 7, 2018
@jcesarmobile jcesarmobile deleted the not-started-error branch November 7, 2018 00:44
Ionitron added a commit that referenced this pull request Nov 7, 2018
## [2.2.1](v2.2.0...v2.2.1) (2018-11-07)

### Bug Fixes

* Show error page if server is not running ([#207](#207)) ([6a2e07e](6a2e07e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants