feat(WebViewLocalServer.java): return 404 error code when a local file is not found #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is not found Currently, the Android version of the plugin always returns http code 200 no matter if the resource you're trying to get exists or not. The iOS version does. This makes the two implementations inconsistent. This tries to fix that and use the same expected behavior in both of them. BREAKING CHANGE: Until now, the Android part of the plugin was returning a 200 http code even though the requested file didn't exist. This behavior was inconsistent with the historical behavior of the iOS webView. This change makes them both work in the same manner but introduces a breaking change for the current Android users that are expecting a 200 http code no matter what and are testing the not found error just by checking if the body is null. fix ionic-team#216
|
Thanks for the PR. Any implications of this that we should be aware of? Are you using Ionic 4 with HTML5 routing by chance? |
|
You're welcome! Regarding the implications, none that I'm aware of apart from the breaking change I described above. Unfortunately, I'm not using Ionic 4 so I haven't been able to check if there were some unexpected side-effects. The way I see it is that the iOS version is already working like that, so my guess is that we may not expect any further implications. |
|
Thanks for the PR. |
|
You're very welcome! Do you have any idea of what will be the estimated release date? |
|
There is no release date, but shouldn't take long. |
jcesarmobile
approved these changes
Dec 12, 2018
Ionitron
added a commit
that referenced
this pull request
Jan 3, 2019
# [3.0.0](v2.3.1...v3.0.0) (2019-01-03) ### Bug Fixes * **iOS:** Remove unused code ([#247](#247)) ([bceb17a](bceb17a)) ### Features * Allows configuration of Mixed Content Mode ([#240](#240)) ([486d412](486d412)), closes [#231](#231) * **Android:** Implement ionic-file and ionic-content urls ([#242](#242)) ([8ef0c30](8ef0c30)), closes [#204](#204) [#183](#183) * **iOS:** Remove GCDWebServer ([#244](#244)) ([0dee0cf](0dee0cf)) * **WebViewLocalServer.java:** return 404 error code when a local file is not found ([#217](#217)) ([f7a551e](f7a551e)), closes [#216](#216) ### BREAKING CHANGES * **iOS:** Sets deployment-target to 11, so will only work on iOS 11+ * Address changes * changes the default from 1 (never) to 0 (always) * **WebViewLocalServer.java:** Until now, the Android part of the plugin was returning a 200 http code even though the requested file didn't exist. This behavior was inconsistent with the historical behavior of the iOS webView. This change makes them both work in the same manner but introduces a breaking change for the current Android users that are expecting a 200 http code no matter what and are testing the not found error just by checking if the body is null.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Android version of the plugin always returns http code 200 no matter if the resource
you're trying to get exists or not. The iOS version does return a specific http code for every case. This makes the two implementations inconsistent. This tries to fix that and get the same expected behavior in both of them.
Note that I've used a 500 code in case the call to the
availablemethod fails. If this is not right let me know and I'll change it. 😉BREAKING CHANGE: Until now, the Android part of the plugin was returning a 200 http code even though
the requested file didn't exist. This behavior was inconsistent with the historical behavior of the
iOS webView. This change makes them both work in the same manner but introduces a breaking change
for the current Android users that are expecting a 200 http code no matter what and are testing the
not found error just by checking if the body is null.
fix #216