Skip to content

Commit

Permalink
Fixing security issue
Browse files Browse the repository at this point in the history
Plugin logs sensitive information and that is considered as a security issue. iOS logs are can be easily accessed by attacker.

References:
https://www.owasp.org/index.php/Mobile_Top_10_2016-M2-Insecure_Data_Storage
https://www.kaspersky.com/blog/starbucks-moves-quick-to-fix-application-security-vulnerability/3510/ (Starbucks for instance had problem with placing sensitive data to iOS logs and that was a big scandal ;-) )
  • Loading branch information
r3ggi committed Feb 20, 2018
1 parent d9bbf38 commit 9802306
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/ios/CDVKeychain.m
Expand Up @@ -69,9 +69,7 @@ - (void) set:(CDVInvokedUrlCommand*)command {
NSString* key = [arguments objectAtIndex:0];
NSString* value = [arguments objectAtIndex:1];
BOOL useTouchID = [[arguments objectAtIndex:2] boolValue];

NSLog(@"SET %@ %@ %d", key ,value, useTouchID);


A0SimpleKeychain *keychain = [A0SimpleKeychain keychain];

if(useTouchID) {
Expand Down

0 comments on commit 9802306

Please sign in to comment.