-
Notifications
You must be signed in to change notification settings - Fork 9
ionic 2 generator filenames don't follow naming conventions #14
Comments
It's worth considering whether these naming conventions should be taken further given the navigation patterns within Ionic. I didn't find it useful to have everything named Instead, I've taken to using I'm curious to find out what other conventions others are trying. Side note: While I realize you need to move issues around for your organizational sanity, you're not going to get much feedback when an issue lands on a repo with 1 watcher (not that I have a better solution to offer). |
I'm cool with .page.ts, .modal.ts, etc. Style 02-02 allows for inventing a small number of additional type names, and this seems to fit that well.
|
I didn't notice when I originally entered this issue in the other repo, but this is actually a duplicate of #8 in this repo. |
what is the best practice for naming files in ionic? on our project we are using names with hyphen i.e. user-service.ts or login-page.ts |
From @jaufgang on March 9, 2017 19:33
When you create a component, page, service, etc with the cli generator, the filenames of the TypeScript files do not follow the naming conventions recommended in the official Angular Style Guide, in particular Style 02-02 and Style 02-03. The files are missing the conventional suffix for the file type.
This may not be a crucial or pressing issue, but for the sake of promoting best practices, I think it would be a good idea for the generator to conform to these standard conventions.
Copied from original issue: ionic-team/ionic-cli#1968
The text was updated successfully, but these errors were encountered: