Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic 2 generator filenames don't follow naming conventions #1968

Closed
jaufgang opened this issue Mar 9, 2017 · 1 comment
Closed

ionic 2 generator filenames don't follow naming conventions #1968

jaufgang opened this issue Mar 9, 2017 · 1 comment

Comments

@jaufgang
Copy link

jaufgang commented Mar 9, 2017

When you create a component, page, service, etc with the cli generator, the filenames of the TypeScript files do not follow the naming conventions recommended in the official Angular Style Guide, in particular Style 02-02 and Style 02-03. The files are missing the conventional suffix for the file type.

This may not be a crucial or pressing issue, but for the sake of promoting best practices, I think it would be a good idea for the generator to conform to these standard conventions.

@jthoms1
Copy link
Member

jthoms1 commented Mar 10, 2017

This issue was moved to ionic-team/ionic-app-generators#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants