Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Intellisense Webstorm doesn't work for angular 2 libraries #52

Closed
jgw96 opened this issue Sep 30, 2016 · 6 comments
Closed

Intellisense Webstorm doesn't work for angular 2 libraries #52

jgw96 opened this issue Sep 30, 2016 · 6 comments

Comments

@jgw96
Copy link
Contributor

jgw96 commented Sep 30, 2016

From @aavelyn on September 30, 2016 8:52

Short description of the problem:

Webstorm won't show autoimport/autocomplete prompts for angular 2 keywords. I think it's because all @angular dependencies aren't on first level (because of ionic-angular)

Deleting node modules and placing all @angular dependencies before ionic-angular and run npm install solves it, but not sure if it'll create conflicts (shouldn't?)

What behavior are you expecting?

Webstorm to shop classic autoimport/autocomplete prompts for @angular keywords

Which Ionic Version? Ionic 2 rc0

Copied from original issue: ionic-team/ionic-framework#8346

@denofevil
Copy link

Hi,
Dennis from WebStorm team here.
Right now we're not indexing indirect dependencies due to performance (more modules -> more indexing, slower code insight) and quality issues (irrelevant variants in code completion and navigation).
We can add some custom logic specially for Ionic projects, but it looks somewhat hackish.
Any chance you can add angular as a direct dependency? That way the package.json will give users better insight of the app dependencies. The Create-React-App uses that approach:

{
 "devDependencies": {
   "react-scripts": "0.4.1"
 },
 "dependencies": {
   "react": "^15.3.1",
   "react-dom": "^15.3.1"
 },
}

What do you think?

@jgw96
Copy link
Contributor Author

jgw96 commented Oct 7, 2016

Hello all! We are looking at moving our deps around a little in the RC.1 release and that should resolve this issue. I am going to keep this issue open as a tracking issue until then. Thanks!

@jthoms1
Copy link
Member

jthoms1 commented Oct 10, 2016

This is the PR that I have that should fix this issue. When we create a base ionic2 it should link to the angular dependencies directly rather than rely on ionic's dependency on angular. @denofevil Does this look like it should fix the WebStorm issue?

ionic-team/ionic2-app-base#87

@denofevil
Copy link

@jthoms1, looks like it should

@jgw96
Copy link
Contributor Author

jgw96 commented Oct 14, 2016

@aavelyn this should be fixed by the above PR. Can you change your package.json to match the changes in the above linked PR and try again please? Thanks!

@jgw96
Copy link
Contributor Author

jgw96 commented Oct 20, 2016

Hello all! I am going to close this issue for now as it should be fixed in the latest release of app-scripts. If you still have issues with this feel free to comment and i will happily reopen. Thanks!

@jgw96 jgw96 closed this as completed Oct 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants