Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

adding ability for rollup plugins to be placed before ion compiler #140

Closed

Conversation

chcaru
Copy link

@chcaru chcaru commented Oct 12, 2016

Short description of what this resolves:

Currently it's not possible have rollup plugins run before the ion compiler plugin. This is sometimes necessary, such as to inline styleUrls as styles using rollup-angular-plugin.

Changes proposed in this pull request:

The proposed changes allow an optional prependPlugins property to be defined on the rollup config. These plugins are prepended to the rollup plugins, after the ion compiler, if prependPlugins exists.

@adamdbradley
Copy link
Contributor

I'd rather not add a non-standard config property if we don't have to. I think what we should do is have ion-compiler show up in the config again so users can adjust where it goes. Also, for production builds with NGC and Ahead of Time compiling, what's the value of inlining styleUrls?

@chcaru
Copy link
Author

chcaru commented Oct 12, 2016

Yeah, I agree, this is probably too hacky. Exposing the ion-compiler in the rollup config is definitely the right way to go.

Mainly view encapsulation. For large enough applications this is extremely handy. Additionally, for my instance, we have a web client that follows this pattern, and we don't want to break the dev flow from one client to the next.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants