Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested IonRouterOutlet docs for React are missing ionPage prop and use outdated live example #2183

Open
amandaejohnston opened this issue Feb 2, 2022 · 0 comments
Open

Nested IonRouterOutlet docs for React are missing ionPage prop and use outdated live example #2183

amandaejohnston opened this issue Feb 2, 2022 · 0 comments
Labels
triage New issues

Comments

@amandaejohnston
Copy link
Contributor

URL
https://ionicframework.com/docs/react/navigation

What is missing or inaccurate about the content on this page?

  1. All inline examples involving nested IonRouterOutlets are missing the ionPage prop from the fix described here: bug: Navigation between pages from different nested IonRouterOutlet's breaks UI due to outlets overlap ionic-framework#20219 (comment) This fix has been merged into the framework for a while.
  2. The codepen under "Live Example" is also missing the fix. It's also using Ionic 5, and should be updated to v6.
@amandaejohnston amandaejohnston added the content Issues related to the contents of the documentation website label Feb 2, 2022
@amandaejohnston amandaejohnston mentioned this issue Feb 2, 2022
Closed
@liamdebeasi liamdebeasi added triage New issues and removed content Issues related to the contents of the documentation website labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage New issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamdebeasi @amandaejohnston