Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View with sub-header Ruins All Other Views #1095

Closed
calendee opened this issue Apr 9, 2014 · 7 comments
Closed

View with sub-header Ruins All Other Views #1095

calendee opened this issue Apr 9, 2014 · 7 comments

Comments

@calendee
Copy link

calendee commented Apr 9, 2014

If a view has a sub-header, the content for all other views will be under the ion-nab-bar.

Sample : http://codepen.io/calendee/pen/FxHiB

In that sample, the "home.html" template has : <ion-header-bar class="bar bar-subheader item-input-inset">.....

The view renders properly. Next, open the menu and choose "Attendees". You can see the scroll area is up under the nav-bar.

Removing the sub-header on the "home" template fixes all layout issues. Adding sub-headers to all views fixes layout issue.

Forum : http://forum.ionicframework.com/t/content-going-below-subheader/2743

@adamdbradley adamdbradley self-assigned this Apr 10, 2014
@ajoslin ajoslin assigned ajoslin and unassigned adamdbradley Apr 11, 2014
@ajoslin ajoslin added core js and removed css labels Apr 11, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Apr 11, 2014

Fixed in nightly :-)

@ajoslin ajoslin closed this as completed Apr 11, 2014
@mhartington
Copy link
Member

@ajoslin I got this from the forum and using the nightly, having a sub-header still messed with things.

http://codepen.io/mhartington/pen/odlCs

@msreekm
Copy link

msreekm commented Apr 16, 2014

Looks like it is still broken ?

@henrysxie
Copy link

I'm having this issue as well...

@ajoslin ajoslin reopened this Apr 29, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Apr 29, 2014

Aha, I see! OK, fixing.

@ajoslin
Copy link
Contributor

ajoslin commented Apr 29, 2014

Fixed, and tested on my end.

Unfortunately, the travis server is down for the rest of the day due to an unrelated problem. It will be up in the nightly build by tonight.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants