Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.17] Expand full button with wrap option #16552

Closed
paulstelzer opened this issue Dec 2, 2018 · 2 comments
Closed

[4.0.0-beta.17] Expand full button with wrap option #16552

paulstelzer opened this issue Dec 2, 2018 · 2 comments
Labels

Comments

@paulstelzer
Copy link
Contributor

Describe the Bug
Sometimes it's necessary to wrap the text of a button because you want to have a long text on this button. If the button is expand="full" or expand="block", this will not working

Steps to Reproduce
Add the following css:

ion-button.wrap {
    white-space: normal;
    --height: auto;
}

And the button is this:

v1:

<ion-button expand="full" class="wrap">
Imagine a very long text here that is very long and will need more than one line
</ion-button>

v2:

<ion-button expand="block" class="wrap">
Imagine a very long text here
</ion-button>

This will lead to (on Chrome):

expand-full-button

Related Code
Problem is the following: contain: strict; on full and block

Expected Behavior
The text should be shown correctly

chrome_2018-12-02_11-01-20

@manucorporat
Copy link
Contributor

Fixed by 802a3d1!

@ionitron-bot
Copy link

ionitron-bot bot commented Jan 1, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants