Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionViewDidEnter does not fire when navigating back to tabbed page #17473

Closed
Eraldo opened this issue Feb 12, 2019 · 5 comments
Closed

ionViewDidEnter does not fire when navigating back to tabbed page #17473

Eraldo opened this issue Feb 12, 2019 · 5 comments
Labels

Comments

@Eraldo
Copy link

Eraldo commented Feb 12, 2019

Bug Report

Ionic version:

[x] 4.x

Current behavior:
When I go navigate from a tabbed page to another page and then use the ion-back-button from there, the tabbed page's ionViewDidEnter method is not triggered.

Video showing the bug live on a different code base:
Video showing the bug live on a different code base:
Expected behavior:

When I click on the back button the ionViewDidEnter method of the tabbed page fires since it has been entered again. (Consistent with non tabbed pages.)

Steps to reproduce:

Issue demo repo: https://github.com/Eraldo/ionic4-tabs-back-issue

  1. Clone the repo
  2. Make sure the latest ionic version is installed.
  3. Run ionic serve.
  4. Close the alert which shows on page enter.
  5. Click on on the ion button in the content section of the page (tab1 page).
  6. On the opened page ("Some" page) click on the back button.
  7. Verify that there is no alert showing up anymore.

Related code:

https://github.com/Eraldo/ionic4-tabs-back-issue

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.2 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.1
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.3.0

System:

   NodeJS : v11.0.0 (/usr/local/Cellar/node/11.0.0/bin/node)
   npm    : 6.7.0
   OS     : macOS Mojave
@ionitron-bot ionitron-bot bot added the triage label Feb 12, 2019
@liamdebeasi
Copy link
Contributor

Hi @Eraldo,

Thanks for opening an issue with. I'm not seeing the content you're describing in your steps to reproduce with the repo you provided. It looks like the base tab starter app. Can you double check to make sure you included the link to the correct repo?

Thanks!

@liamdebeasi liamdebeasi added needs: reply the issue needs a response from the user needs: investigation labels Feb 14, 2019
@ionitron-bot ionitron-bot bot removed the triage label Feb 14, 2019
@Eraldo
Copy link
Author

Eraldo commented Feb 14, 2019

Oh! I forgot to commit before pushing and I already deleted the repo locally. What a pity!
Well I will recreate it today. Thanks for letting me know.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Feb 14, 2019
@Eraldo
Copy link
Author

Eraldo commented Feb 14, 2019

Update: I pushed that the repo: https://github.com/Eraldo/ionic4-tabs-back-issue
Can you please retry. :)

@liamdebeasi
Copy link
Contributor

Thanks @Eraldo,

I was able to reproduce the issue using the code you provided. I am going to close this as a duplicate of #16834. We've added that issue to our backlog and hope to have it resolved soon. 🙂

Thanks for using Ionic!

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 16, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants