Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Missing navigation animations when navigating from tabs #18857

Open
danielsogl opened this issue Jul 23, 2019 · 3 comments
Open

bug: Missing navigation animations when navigating from tabs #18857

danielsogl opened this issue Jul 23, 2019 · 3 comments
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@danielsogl
Copy link
Contributor

Bug Report

Navigating forward from a tab page to another sub-page will not show the router transition animation if the sub-page is listed inside the tabs.router.module.ts

Ionic version:

[x] 4.6

Current behavior:

In my application I wanna show the tabs all the time also on sub pages. To react this case I have to list my subpages inside the tabs.router.module.ts file.
If I navigate now from Tab1 to Page1, there will be no router transition animation and the back button usage is not that intuitive anymore.

Expected behavior:

It should be possible to navigate from tabs to pages listed as subpages inside the tabs.router.module.ts file with router transition animations and back button support oob.

Steps to reproduce:

  1. Create an new tabs project
  2. Create a empty page
  3. Add the page as a sub page inside the tabs.router.module.ts file
  4. Navigate forward to the child page

Related code:

import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';
import { TabsPage } from './tabs.page';

const routes: Routes = [
  {
    path: 'tabs',
    component: TabsPage,
    children: [
      {
        path: 'tabDatesRoot',
        children: [
          {
            path: '',
            loadChildren: '../pages/dates/dates.module#DatesPageModule'
          }
        ]
      },
      {
        path: '',
        redirectTo: '/tabs/tabDatesRoot',
        pathMatch: 'full'
      },
      {
        path: 'pages',
        children: [
          { path: 'map', loadChildren: '../pages/map/map.module#MapPageModule' },
        ]
      }
    ]
  },
  {
    path: '',
    redirectTo: '/tabs/tabDatesRoot',
    pathMatch: 'full'
  }
];

@NgModule({
  imports: [RouterModule.forChild(routes)],
  exports: [RouterModule]
})
export class TabsPageRoutingModule {}

Ionic info:

Ionic:

   Ionic CLI                     : 5.2.3 (/Users/danielsogl/.nvm/versions/node/v12.4.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.6.2
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Capacitor:

   Capacitor CLI   : 1.1.1
   @capacitor/core : 1.1.1

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.4.0 (/Users/danielsogl/.nvm/versions/node/v12.4.0/bin/node)
   npm    : 6.10.1
   OS     : macOS Mojave```
@ionitron-bot ionitron-bot bot added the triage label Jul 23, 2019
@simetin
Copy link

simetin commented Aug 2, 2019

Hi ! I have create a repo illustrating the issue. https://github.com/simetin/ionic-tabs-nav. The problem appears in tabs when you try to navigate to a page that is not a child of one of the tabs. Hope it helps !

@simetin
Copy link

simetin commented Aug 7, 2019

Ping

@liamdebeasi liamdebeasi added type: bug a confirmed bug report package: angular @ionic/angular package labels Oct 31, 2019
@ionitron-bot ionitron-bot bot removed the triage label Oct 31, 2019
@jamt0
Copy link

jamt0 commented May 2, 2021

Same error en react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

4 participants