Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0-rc.0: ion-content height 100% not inherited #20305

Closed
ghost opened this issue Jan 27, 2020 · 7 comments
Closed

5.0.0-rc.0: ion-content height 100% not inherited #20305

ghost opened this issue Jan 27, 2020 · 7 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 27, 2020

Ionic version:
[x] 5.0.0-rc.0

Current behavior:
In Ionic 5.0.0-rc.0 it is no longer possible to assign a height: 100% to the split element of the ion-content property, respectively, this property will be ignored.

Expected behaviour:
Still able to use height: 100% for content with Ionic 5.0.0-rc.0.

@ionitron-bot ionitron-bot bot added the triage label Jan 27, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you provide a code example of what you are trying to do?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jan 27, 2020
@ionitron-bot ionitron-bot bot removed the triage label Jan 27, 2020
@ghost
Copy link
Author

ghost commented Jan 27, 2020

thank you for your reply.

I try :

<ion-content>
    <ion-grid style="height: 100%">
    </ion-grid >
</ion-content>

and

<ion-content>
    <ion-grid style="min-height: 100%">
    </ion-grid >
</ion-content>

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jan 27, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the follow up. Can you give the following dev build a try and let me know if it resolves your issue: 5.0.0-dev.202001271550.1c2d648

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jan 27, 2020
@ionitron-bot ionitron-bot bot removed the triage label Jan 27, 2020
@ghost
Copy link
Author

ghost commented Jan 27, 2020

It works as expected, thanks for your help.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jan 27, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #20309 and will be available in an upcoming release of Ionic Framework.

@paulstelzer
Copy link
Contributor

Thanks! Had the same issue with rc.0 and now it's working like before. good job!

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 26, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants