Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: header containing collapsible large title should use content background always #20691

Closed
brandyscarney opened this issue Mar 4, 2020 · 1 comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Mar 4, 2020

Bug Report

Ionic version:

[x] 5.x

Current behavior:

Theme an app by adding at least the following variable:

:root {
  --ion-toolbar-background: red;
}

Screen Shot 2020-03-04 at 11 32 14 AM

Expected behavior:

The large title toolbar should just use the content background since it needs to blend with the header above. Adding the following CSS to an app overrides this behavior:

/* TODO remove once fixed in framework */
.ios .header-collapse-condense ion-toolbar {
  --background: var(--ion-background-color, #fff);
}

Screen Shot 2020-03-04 at 11 34 47 AM

Steps to reproduce:

This can be reproduced in the conference app by commenting out the added code above.

Related code:

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here
@brandyscarney brandyscarney added package: core @ionic/core package type: bug a confirmed bug report labels Mar 4, 2020
@brandyscarney brandyscarney changed the title bug: header above large title should use content background always bug: header containing collapsible large title should use content background always Mar 4, 2020
@liamdebeasi liamdebeasi added this to the 5.0.5 milestone Mar 10, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Apr 10, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants