Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ipadOS fullsize modal / presentingElement not getting cardStyle #22422

Closed
sbittmann opened this issue Nov 3, 2020 · 2 comments
Closed
Labels

Comments

@sbittmann
Copy link

sbittmann commented Nov 3, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:

Actual its not possible to make a fullscreen modal on ipadOS with changing the presentingElement (ion-app) to backgroundCard

Expected behavior:

The presentingElement for example ion-app should get cardStyle and in top of the app there should be a blackspace.
This Site has been mentioned in a previous Issue (#20255), please take a note on the "Extra Extra Extra Large content size" on ipadOS.
https://hacknicity.medium.com/view-controller-presentation-changes-in-ios-13-ac8c901ebc4e

Steps to reproduce:

Use the modal example from the documentation.
(https://ionicframework.com/docs/demos/api/modal/index.html?ionic:mode=ios)
Create big modal.
Add presentingElement
Open modal on ios screensize and the presentingElement gets nice cardStyle Animation.
Open same modal with ipad-screensize and the presentingElement is not changing.

Related code:
See https://github.com/sbittmann/ionicCardStyleIssue

Other information:

I think problem is based in
ionic-framework/core/src/components/modal/animations/ios.enter.ts
Line 31-32:

  if (presentingEl) {
    const isMobile = window.innerWidth < 768;

And Line 44:

    if (isMobile) {
@ionitron-bot ionitron-bot bot added the triage label Nov 3, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. I am going to close this as this is not a bug in Ionic Framework. The "card style modal" on iPadOS is not supposed to show up in the same way as it does on an iPhone. I tested this out in a native Swift application on devices running iOS 14, and this is what the swipeable modals look like:

iPhone 12 iPad Pro (11 inch)
Screen Shot 2020-11-03 at 9 21 40 AM Screen Shot 2020-11-03 at 9 21 38 AM

I was not able to reproduce the "ExtraExtraExtraLarge" content size category on iOS 14 with an iPad Pro 11 inch, nor was I able to find it used in any native apps, so I don't think it is used anymore in iOS 14. I can only find the "ExtraExtraExtraLarge" content size option in the Apple Developer Docs in the context of fonts: https://developer.apple.com/search/?q=ExtraExtraExtraLarge&type=Documentation

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 3, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants