Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: picker column does not account for pressing when computing velocity #23034

Closed
devinova opened this issue Mar 11, 2021 · 6 comments
Closed
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@devinova
Copy link

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
The component picker-column does not select the correct element, as it is not waiting for the user to hold the touch or click for a while after a slide.

Expected behavior:

Steps to reproduce:
1 - Access the official website: https://ionicframework.com/docs/api/picker

2 - Move the column quickly but keep the mouse pressed and see that when you release the mouse button it will not select the element that is showing why it is still calculating the initial drag speed, but that speed should no longer exist.

Gravacao.de.Tela.2021-03-11.as.12.18.13.mov

Other information:
I also tested it directly on the official Ionic framework project and the problem still persists. I made a temporary correction, but I would like to know if there is already an official solution to this issue.

@liamdebeasi
Copy link
Contributor

Thanks for the issue. We are tracking all datetime/picker issues in #16630, so I will add your issue there.

@devinova
Copy link
Author

Thanks for the feedback. I would like to take one more question, I downloaded the official project and made a correction for this problem, how do I make a pull request with this correction?

@liamdebeasi
Copy link
Contributor

Check out our Contributing Guide: https://github.com/ionic-team/ionic-framework/blob/master/.github/CONTRIBUTING.md#creating-a-pull-request

Let me know if you have any questions!

@ionitron-bot
Copy link

ionitron-bot bot commented Apr 10, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 10, 2021
@liamdebeasi liamdebeasi reopened this Mar 2, 2022
@liamdebeasi liamdebeasi changed the title bug: bug: picker column does not account for pressing when computing velocity Mar 2, 2022
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Mar 2, 2022
@ionitron-bot ionitron-bot bot removed the triage label Mar 2, 2022
@ionic-team ionic-team unlocked this conversation Mar 28, 2023
@liamdebeasi
Copy link
Contributor

Hi everyone,

In the next major version of Ionic we will be introducing a new picker component where this issue is resolved: #28689

I am going to close this since the work required to resolve this issue has been merged. Please let me know if there are any questions.

Copy link

ionitron-bot bot commented Jan 13, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants