Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): minutes only filtered when max hour matches current hour #24710

Merged
merged 1 commit into from Feb 4, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The max value for ion-datetime will filter the minute selection for all hours. This means if the max value is "19:30", users are only able to select minutes 0-30 within hour 19 (correct), but when within hour 18, they are still only able to select minutes 0-30 (incorrect).

Issue Number: #24702

What is the new behavior?

The max time constraint will only filter minute selections when the max time hour matches the current hour. This means that when max constraint is "19:30" and the hour is 19, users will only be able to select 0-30. When the hour is 18, users will be able to select 0-60.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sean-perkins sean-perkins requested a review from a team as a code owner February 3, 2022 18:46
@github-actions github-actions bot added the package: core @ionic/core package label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants