fix(all): long press now preserves activated state #25551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25544
See #25544 (comment) for technical explanation.
What is the new behavior?
contextmenu
event listeneronMouseDown
function to return early if the secondary mouse button was pressed.Note: This change means that the
.ion-activated
class will remain when long pressing on a button. However, long pressing does not necessarily mean the browser will fire aclick
event. The tap click utility should not be used as an indicator as to whether or not a click event will fire as the browser can cancel it for various reasons. This behavior brings Android in line with iOS (iOS does not firecontextmenu
at the moment, so this bug never happened on iOS).Does this introduce a breaking change?
Other information