Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): setting max/min does not increase number of nodes rendered #26065

Merged
merged 8 commits into from Oct 10, 2022

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Oct 3, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26059

Setting min/max on the wheel picker caused the number of nodes initially rendered to increase. This is wrong as setting the max to 10 years in the future causes the wheel picker to render 1000s of nodes. Instead, the wheel picker should render as a sliding window of 3 months and lazily load future/past dates.

What is the new behavior?

  • Updates the sliding window logic so only 3 months of data is rendered at a time.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 3, 2022
@liamdebeasi liamdebeasi changed the title Fw 2537 fix(datetime): setting max/min does not increase number of nodes rendered Oct 3, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 3, 2022 16:18
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 3, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime preferWheel min/max increases the number of dates initially rendered
2 participants