Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): header renders correct date #26120

Merged
merged 4 commits into from Oct 13, 2022
Merged

fix(datetime): header renders correct date #26120

merged 4 commits into from Oct 13, 2022

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Oct 13, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26116

The title formatter logic only checked if activeParts was an array, not if multiple="true". As a result, when the activeParts variable was refactored to an array in 0aee328, "0 days" started showing on single-select datetimes with no value.

This does not impact ion-datetime-button as that component checked for multiple="true".

What is the new behavior?

  • The title formatter for multiple date selection only renders when multiple="true".

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title Fw 2631 fix(datetime): header renders correct date Oct 13, 2022
@github-actions github-actions bot added the package: core @ionic/core package label Oct 13, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 13, 2022 13:38
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 13, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime header shows 0 days selected with no value even if multiple="false"
3 participants