Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): selecting days updates value #26121

Merged
merged 15 commits into from Oct 13, 2022
Merged

fix(datetime): selecting days updates value #26121

merged 15 commits into from Oct 13, 2022

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Oct 13, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A internal ticket

When working on 0aee328, I forgot to apply these changes any place where this.activeParts was used to call setActiveParts. As a result the following issues occurred:

  1. Selecting day, month, and year wheel items caused the value to not get updated when the value was not initially set.
  2. Selecting a date in the calendar grid caused the time to not get set to today's time when the value was not initially set.

What is the new behavior?

  • The value property is now updated correctly even when no value is initially set.

Note this.getDefaultPart() returns either the selected date or the "default" date. This allows us to fallback to showing today's date without considering today's date to be the "selected" date.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 13, 2022
@liamdebeasi liamdebeasi changed the title fix(datetime): selecting item in wheel updates value fix(datetime): selecting days updates value Oct 13, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 13, 2022 14:49
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 13, 2022 14:49
@liamdebeasi liamdebeasi merged commit d76a24d into main Oct 13, 2022
@liamdebeasi liamdebeasi deleted the FW-2632 branch October 13, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants