Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): on-off icon is not announced by screen readers #26641

Merged
merged 3 commits into from Jan 19, 2023

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Jan 18, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The icons rendered when enableOnOffLabels is turned on may be read by screen readers, despite being purely decorative.

Issue URL: N/A

What is the new behavior?

Icon now has aria-hidden="true".

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jan 18, 2023
@amandaejohnston amandaejohnston marked this pull request as ready for review January 18, 2023 22:35
@amandaejohnston amandaejohnston requested a review from a team as a code owner January 18, 2023 22:35
@amandaejohnston amandaejohnston merged commit 77ccac0 into main Jan 19, 2023
@amandaejohnston amandaejohnston deleted the FW-2109 branch January 19, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants