fix(modal): keyboard listener removed on dismiss #26856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
liamdebeasi
changed the title
liamdebeasi
commented
Feb 24, 2023
| @@ -333,7 +333,7 @@ export class Modal implements ComponentInterface, OverlayInterface { | |||
| if (this.gesture) { | |||
| this.gesture.enable(enable); | |||
| } else if (enable) { | |||
| await this.initSwipeToClose(); | |||
| this.initSwipeToClose(); | |||
There was a problem hiding this comment.
This method is not async, so it does not need await
8 tasks
amandaejohnston
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Part of #26833
The keyboard listener is added after the transition completes. This means that if you present and dismiss a modal quickly, the dismiss method will run before the keyboard listener is added. This is because the dismiss method only waits for the transition to finish before proceeding. As a result, the keyboard listener is never removed.
What is the new behavior?
dismiss. Note that the callback already checks to see if the gesture is configured so we can safely add this listener before the gestures are fully configured.Does this introduce a breaking change?
Other information