-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: vue, root direction does not unmount wiped views #27191
Comments
Thanks for the issue! This issue has been labeled as Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed. If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue. For a guide on how to create a good reproduction, see our Contributing Guide. |
I have added the StackBlitz url for the demo in the description and see below as well. Don't forget to turn on the VueDev tools to see the main problem. https://stackblitz.com/edit/vitejs-vite-yj2kdn?file=src/components/HelloWorld.vue |
Any update on this? Did the StackBlitz reproduction help? |
Thanks, I can reproduce this. Views 1 and 2 should be unmounted when using |
Any update on this issue? We need this fixed in our app. Only solution right now is to downgrade to older version where it worked so i wont be able to go back from Homepage after login. |
@pivko420 I am also waiting for the changes to get fixed but it looks like I may have to end up providing the PR for the fix if there is no activity by next week as this is a significant issue in our app. We have for the time being temporarily closed out the forward navigation flow and made all of them root. |
I use package.json |
@pivko420 |
This is still a issue for all. all navigation is boggy. it shows the right url but the view is wrong. is like old view do not die. |
I'm facing same issue with latest @ionic/vue-router 7.7.0. This solve my issue, the ion-router-outlet seem store only the current route but it works |
Prerequisites
Ionic Framework Version
v6.x
Current Behavior
Navigating forward mode with at least 3 forward navigation and then triggering root navigation after the third or more forwarded route does not clean up the mapping of the IonRouterOutlet components completely but only removes 1 Component from the stack and pushes the root element.
Expected Behavior
The expected behavior is that the IonRouterOutlet should reset the stack and start from scratch if the direction is root but it does not you can see the screenshots of stacks created in the Steps to Reproduce.
Steps to Reproduce
Here are step by step for current behavior with VueDev Tool screenshots
The initial state starting at DashboardView
Root Navigation to ForumsView
Forward Navigation to TopicView
Another Forward Push to ThreadView
Final Redirection to Dashboard using root as router-direction
Code Reproduction URL
https://stackblitz.com/edit/vitejs-vite-yj2kdn?file=src/components/HelloWorld.vue
Ionic Info
Additional Information
In the IonRouterOutlet component implementation of vue package through debugging i see that action of call unmountLeaving views only being looped once.
I have added the links to the actions below.
ionic-framework/packages/vue-router/src/viewStacks.ts
Line 190 in 114fe28
https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonRouterOutlet.ts#L400
The text was updated successfully, but these errors were encountered: