fix(datetime): prefer wheel sets working value on confirmation #28520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
liamdebeasi and
amandaejohnston
as code owners
amandaejohnston
approved these changes
Nov 15, 2023
liamdebeasi
reviewed
Nov 16, 2023
liamdebeasi
reviewed
Nov 21, 2023
liamdebeasi
reviewed
Nov 22, 2023
liamdebeasi
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #25839
What is the current behavior?
Confirming the working day when a datetime using a wheel picker without an initial value will result in a value of
undefinedinstead of the displayed working day the user sees.What is the new behavior?
preferWheeluses the working value on confirmationDoes this introduce a breaking change?
Other information
Dev-build:
7.5.7-dev.11701896424.13d40ac9Co-authored-by: liamdebeasi liamdebeasi@users.noreply.github.com