Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio-group): radio disabled prop can be undefined #28712

Merged
merged 2 commits into from Dec 28, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 15, 2023

Issue number: resolves #28677


What is the current behavior?

Defining disabled a @Prop() disabled = false causes Stencil to mark this property as optional. This behavior is not desired on our end, but making the property required would be a breaking change. Additionally, the root issue is due to how Stencil resolves types.

For example, disabled is optional in the LocalJSX namespace but required in the Components namespace. Addressing this inside of Stencil is significant breaking change. As a result, the team has decided to compromise and support the falsy disabled state for radio for now. Other Ionic components that support the disabled prop also check for falsy values.

Stencil plans to de-risk this in https://ionic-cloud.atlassian.net/browse/STENCIL-917.

What is the new behavior?

  • Radio Group now looks at falsy values instead of strictly checking false.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.6.2-dev.11703182244.1165aeec

@github-actions github-actions bot added the package: core @ionic/core package label Dec 15, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review December 21, 2023 18:20
@liamdebeasi liamdebeasi requested a review from a team December 21, 2023 18:20
@liamdebeasi liamdebeasi added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit 75ffeee Dec 28, 2023
56 checks passed
@liamdebeasi liamdebeasi deleted the FW-5783 branch December 28, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: radio button disabled prop doesn't handle undefined
3 participants