fix(radio-group): radio disabled prop can be undefined #28712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28677
What is the current behavior?
Defining disabled a
@Prop() disabled = false
causes Stencil to mark this property as optional. This behavior is not desired on our end, but making the property required would be a breaking change. Additionally, the root issue is due to how Stencil resolves types.For example,
disabled
is optional in the LocalJSX namespace but required in the Components namespace. Addressing this inside of Stencil is significant breaking change. As a result, the team has decided to compromise and support the falsydisabled
state for radio for now. Other Ionic components that support thedisabled
prop also check for falsy values.Stencil plans to de-risk this in https://ionic-cloud.atlassian.net/browse/STENCIL-917.
What is the new behavior?
false
.Does this introduce a breaking change?
Other information
Dev build:
7.6.2-dev.11703182244.1165aeec