New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(searchbar): update styles to iOS 17 specs #28728
Conversation
This will cause playwright to generate new image diffs since the opacity and background changes are lower than the tolerance.
c62195c
to
c93b69a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, verified against the iOS native Calendar app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the cancel text also got larger. I can reproduce it using the images in your description as well as my own images taken from my device:
Another thing I noticed when looking at the Searchbar in Safari on iOS is that when the text centers the search icon doesn't center with it. I am not sure if this is new with iOS 17 and I can't find another app where it centers but we might want to add this as "out of scope" for now.
@brandyscarney good catch on the cancel button text. Updating the screenshots now. I'm not sure i follow the Safari comment. Developers can add |
You're right, I can't find any other examples where the searchbar behaves that way in iOS. I also tried reproducing it in SwiftUI but their default is left aligned. I see what you're saying that users can center it, but it doesn't give the animation like we have in our docs when it is centered that way (see the last example). It might be good to note it either way, that we chose not to change the animated implementation to leave the icon static. |
Looks like I got tagged as a reviewer due to a flaky screenshot update. Going to remove myself from a review since this PR already has 2 reviewers. |
Issue number: Internal
What is the current behavior?
The searchbar implementation for Ionic's iOS mode does not align with the appearance of a native search control in iOS 17.
What is the new behavior?
12px
.17px
.$text-color-rgb
, which is compatible with dark mode appearance. Ionic does not currently have rgb variables for step colors to closer align to iOS color when requiring opacity.searchbar/test/basic
, with a modified content background color of#f2f2f7
to closer align to the Notes app.Does this introduce a breaking change?
Other information
The additional screenshot diffs that are a part of this PR are valid changes. When updating the color palette for AA contrast, these reference images were not updated. We currently use a threshold that determines if a diff exists. The reason that they show up in this PR is because I manually deleted the reference images and forced new references. As such the text color changes you see here are actually from the AA contrast changes.