Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetime-button): update design to match iOS 17 spec #28730

Merged
merged 10 commits into from Dec 20, 2023
Merged

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 18, 2023

Issue number: N/A


What is the current behavior?

Datetime button combines Material Design and iOS styles.

What is the new behavior?

  • Splits the styles into their own mode files for Material Design & iOS and updates the iOS styles to match iOS 17.
  • Updates the basic test to include a screenshot test in both modes & directions.

I removed all of the datetime button screenshots before running the action to generate screenshots. Some screenshots were not added back but this is correct for the following reasons:

I can add these back if you want since they aren't part of this PR but they should have probably been removed when the test was updated to exclude directions/modes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I compared the datetime button against native iOS 17.1.2:

iOS 17 Ionic
ios17 ionic
ios17 ionic

Diff:

diff

@github-actions github-actions bot added the package: core @ionic/core package label Dec 18, 2023
@brandyscarney brandyscarney marked this pull request as ready for review December 18, 2023 23:11
@brandyscarney brandyscarney requested a review from a team December 18, 2023 23:11
@brandyscarney brandyscarney marked this pull request as draft December 19, 2023 15:02
@brandyscarney brandyscarney marked this pull request as ready for review December 19, 2023 15:28
@brandyscarney brandyscarney merged commit 4649637 into FW-4845 Dec 20, 2023
44 checks passed
@brandyscarney brandyscarney deleted the FW-5734 branch December 20, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants